14 comments

  • dlcarrier 1 hour ago
    SimCity had a read-after-free bug that Microsoft patched in Windows 95. That was a lot easier for customers than having Maxis fix it, which could have required exchanging copies of the game.
    • Cthulhu_ 3 minutes ago
      It feels like graphics drivers do / did this a lot too. At the very least they make specific optimizations for specific games, probably by tweaking settings and features that the game developers didn't optimize properly themselves.
  • hodgehog11 2 hours ago
    I think we're starting to see more of this sort of thing happening now with Proton and Wine gaining prominence in the Linux community. Some games (Elden Ring comes to mind) have bad enough PC ports when they come out that the compatibility layer can incorporate a hotfix to improve performance, while users of the software on the original platform still had to suffer.
    • Gigachad 1 hour ago
      Fairly sure GPU drivers do the same thing where they include a ton of per game tweaks to make them run faster. It does feel like a fragile way of doing things where an external component that should be agnostic to the software running ends up including a handful of junk trying to fix stuff that should have been fixed by the consumer of the driver.
      • Guvante 29 minutes ago
        It goes the other way too, sometimes you trigger some optimization silliness in the driver and the game needs to adapt to avoid it.
        • rickdeckard 3 minutes ago
          then the driver gets updated and the game either continues to optimize (wrong) or branches out into code that was written before that driver came out and generally wasn't that well tested, and the circle continues...

          It's the life of a (game) developer...

    • anilakar 1 hour ago
      GPU driver packages are already a huge collection of workarounds for bad game engine coding.

      An Nvidia employee once told me that one of the easiest ways to squeeze out a few extra frames on your old machine is to rename the game executable to hl2.exe.

      • st_goliath 22 minutes ago
        > GPU driver packages are already a huge collection of workarounds for bad game engine coding.

        And of course, browser engines also do the same things for certain websites:

        https://github.com/WebKit/WebKit/blob/main/Source/WebCore/pa...

        https://github.com/WebKit/WebKit/blob/main/Source/WebCore/pa...

      • necovek 20 minutes ago
        I can see how it can modify GPU driver behavior, but I cannot see how it would get you better performance with everything else the same?

        What it should do is ensure some things not relevant to Half-Life 2 were not done, thus getting better performance for this game in particular, but there is no guarantee that same optimizations work for other applications or games, so one should not expect an overall improvement.

        Unless they are doing some silly things like dropping quality, but that's the "everything else the same" point.

        If not, why not have this enabled as default behavior instead?

      • limflick 50 minutes ago
        > to rename the game executable to hl2.exe

        This seems genuinely unbelievable. Does anyone have a technical explanation for this?

        • hurtigioll 43 minutes ago
          gpu drivers detect games, among other thing by looking at executable names

          then driver "optimizes" behavior, sometimes dishonestly (reducing precision), sometimes honestly (working around game engine stupidity)

          • limflick 18 minutes ago
            Couldn't that also cause glitches since optimizations meant for HL2 might not work for, say San Andreas? I understand some optimizations might be universal but I can't help but think about unexpected behavior.
            • ChocolateGod 3 minutes ago
              [delayed]
            • tester756 17 minutes ago
              Who's problem is this?

              Nvidia probably doesnt officially say anything about this and 99.9% of people do not rename process name

      • proton_9 1 hour ago
        This sounds like a really interesting story, would like to read more on why half life 2 specifically? the game itself was pretty well optimized and ran on really low end hardware even back in the day.
        • db48x 57 minutes ago
          Because everyone reported performance metrics using it as a benchmark. Higher number = more sales.
          • murderfs 52 minutes ago
            If you go back 5 years, everyone was using Quake 3 Arena as the benchmark. ATI got in some hot water because if you renamed quake3.exe to quack3.exe, your FPS would drop by 15%, because they were silently reducing quality to juice their benchmark numbers.
            • jkrejcha 7 minutes ago
              Apparently people did this with the DirectX "3D Tunnel" demo as well[1] back over 20 years ago.

              Also of the one "that checked if you were printing a specific string used by a popular benchmark program. If so, then it only drew the string a quarter of the time and merely returned without doing anything the other three quarters of the time".

              [1]: https://devblogs.microsoft.com/oldnewthing/20040305-00/?p=40...

            • tester756 18 minutes ago
              5 or 50? I'd say 5 years ago it was already Witcher 3, Cyberpunk 2077, GTA 5, etc.
    • harrall 1 hour ago
      A big portion of GPU driver updates are actually just that, same with Windows updates.

      Windows 95 patched a bug in SimCity just to get it to work.

  • psanchez 1 hour ago
    This reminds me of a story from 15 years ago, where I was developing a technology to download games on demand by hooking into the OS calls.

    There was a particular game that was superslow when this tech was applied. Original game loading took around 15-20 seconds, whereas once the tech was applied it took easily 3-5 min, even with all data already downloaded.

    When I started digging into it, I realized the reason was the game was using something like

       fread(data, 1, 65536, fptr);
    
    instead of

       fread(data, 65536, 1, fptr);
    
    Which basically expanded back in the day to 65k reads of 1 byte for several MB file. Each fread translated to 65k reads of ReadFile Windows API. Since my code was hooking on ReadFile system call, and my call was heavier than ReadFile, the game loading felt really slow. Unusable. It would have not been fun for players.

    The easy fix was to swap arguments for certain calls. The long fix required to use an internal cache to account for these cases so that the hooked ReadFile was faster when data was already in disk.

    Funny thing is that as we started rolling out the tech and applying it to more and more games we realized lots of games did this. We went for the cache fix and games ended up loading faster than before. Honestly, games could have load all the data in a couple of seconds by just swapping the args. I'm guessing developers did this on purpose so that games seemed like they were loading a lot of stuff, although you never know.

    • Taniwha 32 minutes ago
      I used to be a graphics card/chip architect for macs in the early/mid 90s - our chips were the fastest, but some programs were resistant because they did stupid stuff: pagemaker invalidated the font cache every time it went thru its main loop, quark with ATM did an n*2 thing every time it wrote text etc etc. We had special hardware to accelerate text drawing and it did nothing because the software pissed it away. We considered creating a plugin that fixed all these things, it would have been hard to maintain, in the end we travelled around to the people who made these apps and talked them through their problems

      To be fair excel would erase places white that it wanted to write up to 9 times before it drew any black pixels, we made that very fast! we didn't tell them :-)

      At the time 24-bit framebuffers were so slow that before we built graphics acceleration hardware people would switch back to 8-bit to get stuff done, making 24-bit/true colour your daily driver was a big step forward.

  • selcuka 1 hour ago
    To be fair it is possible that the developer enabled a special "unroll all loops, no matter what" optimisation flag during compilation.

    I agree it would be stupid for a compiler to even support such a flag, but those were the 1980s/90s.

  • kazinator 53 minutes ago
    > Anyway, my colleague found that there was one program that needed to allocate around 64KB of memory on the stack and initialize it. The standard way of doing this is to perform a stack probe to ensure that 64KB of memory is available, then subtracting 65536 from the stack pointer, and then initializing the memory in a small, tight loop.

    Actually, the standard way of allocating 64 kB of memory on the stack is to just assume you can do it, subtract 64k from the stack pointer, and hope for the best.

    Most stack allocations in the wild are not checked.

  • classichasclass 2 hours ago
    Betting Alpha was the native architecture in question. It seemed to have the best support.
  • electroglyph 1 hour ago
    heh, when Raymond Chen dunks on the MSVC team =)
  • notorandit 2 hours ago
    > they fixed it during emulation

    It means the fix was applied to run during the emulation loop execution, not that the fix was found and applied while the emulation loop was running.

    Which would have made it an emulation code escape.

  • jeffbee 1 hour ago
    People from Transmeta told me stories about how their translators were full of special case optimizations to fix horrors they discovered in Microsoft Windows itself.
  • ant6n 24 minutes ago
    Arguably more of an optimization, rather than a fix. Looks like un-unrolling a loop, or better, rolling a loop. Or rolling straight line code?
  • m1r 2 hours ago
    Couldn't they just turn the optimization off for this loop?
    • MadnessASAP 2 hours ago
      They didn't have the code for the offensive program, they were creating the emulator to run it on a different architecture.
    • notorandit 2 hours ago
      Which optimizer replaces a 64k loop with 64k instructions?

      Ah, yes. Microsoft's!

      • selcuka 1 hour ago
        There is no indication that the compiler that produced the code was Microsoft's. Actually the article hints otherwise ("[...] whatever compiler was used to compile this code").
  • yieldcrv 1 hour ago
    > All in all, it took this program 256 kilobytes of code to initialize 64 kilobytes of data.

    solidity sweating profusely

  • rohitsriram 26 minutes ago
    [flagged]